fix(world): check namespace exists before balance transfer [L-03] #2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 962af4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 30 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
holic
reviewed
Jan 10, 2024
| @@ -37,6 +38,9 @@ contract BalanceTransferSystem is System, IWorldErrors { | |||
| revert World_InvalidResourceType(RESOURCE_NAMESPACE, toNamespaceId, toNamespaceId.toString()); | |||
| } | |||
|
|
|||
| // Require the namespace to exist | |||
| if (!ResourceIds.getExists(toNamespaceId)) revert World_ResourceNotFound(toNamespaceId, toNamespaceId.toString()); | |||
|
|
|||
| // Require caller to have access to the namespace | |||
| AccessControl.requireAccess(fromNamespaceId, _msgSender()); | |||
There was a problem hiding this comment.
I wonder how much gas we'd incur if we added this check in requireAccess instead?
edit: see #2105
holic
previously approved these changes
Jan 10, 2024
alvrs
reviewed
Jan 10, 2024
packages/world/src/modules/core/implementations/BalanceTransferSystem.sol
Outdated
Show resolved
Hide resolved
Co-authored-by: alvarius <[email protected]>
…lance-transfer-lost
|
just added a |
|
This PR is failing integration tests because |
|
Using the |
holic
previously approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.